No san check #71
Merged
No san check #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in GH issue #13, we don't need to run these checks as they're already done in IO::Socket::SSL.
|
@noxxi Can I get your review on this, please? |
noxxi
approved these changes
Jun 14, 2023
karenetheridge
approved these changes
Jun 14, 2023
oalders
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove _in_san and _cn_match. Empty out the _check_sock hook.
As pointed out in #13, we don't need to run these checks
as they're already done in
IO::Socket::SSL.Remove the test file,
method_in_san.tas its sole purpose was to test these two methods we've now removed.