Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds coverage tests #51

Merged
merged 2 commits into from Jun 4, 2017
Merged

Adds coverage tests #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8b95b
Testing with coverage
JJ May 28, 2017
7c2b876
Getting the coverage tests from @moose
JJ May 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -13,3 +13,5 @@
/pm_to_blib
.tidyall.d
xx*

*~
16 changes: 16 additions & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -8,8 +8,24 @@ perl:
- "5.14"
- "5.12"
- "5.10"
matrix:
include:
- perl: 5.24
env: COVERAGE=1 # enables coverage+coveralls reporting
sudo: false
before_install:
- git clone git://github.com/travis-perl/helpers ~/travis-perl-helpers
- source ~/travis-perl-helpers/init
- build-perl
- perl -V
- build-dist
- cd $BUILD_DIR # $BUILD_DIR is set by the build-dist command
install:
- cpan-install ExtUtils::MakeMaker --deps
- cpan-install --coverage
before_script:
- coverage-setup
script:
- prove -l -j$(test-jobs) $(test-files) # parallel testing
after_success:
- coverage-report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like most of these are just the default perl-helpers behaviour. Have you tried seeing what happens if we delete everything that aligns with the defaults and try:

before_install:
  - eval $(curl https://travis-perl.github.io/init) --auto

?

See https://github.com/travis-perl/helpers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to. Took me a while to debug the file. What that file does is to create a helper dir and update it. Not too fond of these shell scripts. Anyway, we need prove and we need coverage report, so I will leave these one as they are.

2 changes: 1 addition & 1 deletion dist.ini
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ author = Gisle Aas <gisle@activestate.com>
license = Perl_5
main_module = lib/LWP/Protocol/https.pm
copyright_holder = Gisle Aas
copyright_year = 1997-2016
copyright_year = 2017
version = 6.06

; Gather stuff in
Expand Down