Add defined check

[manwar]

Hi @oalders

Please review the PR.
This was assigned to me as November month assignment by Pull Request Club.

Many Thanks.
Best Regards,
Mohammad S Anwar

[coveralls]

Coverage remained the same at 77.419% when pulling 918cf43 on manwar:proposed-minor-improvements into 14df39e on libwww-perl:master.

[oalders]

Thanks @manwar. I think I understand what you're doing, but it's not clear to my why you're using our rather than my here. Having said that, I wonder if we'd be better off using something like Const::Fast here, if we were ok with the added dependencies.

[manwar]

@oalders there is no particular reason of using "our". I am happy to change to whatever you suggest to.

[oalders]

Ok, I've asked for others to comment on this as well, so maybe hold off before making any changes. :)

[karenetheridge]

I'm not a fan of changing the use of these strings -- it adds cognitive load to have to keep referring elsewhere in the document to see what these values are.

The defined check is great.

[manwar]

@karenetheridge I have removed the changes completely and kept just defined check.
Is this any good?

[oalders]

Thanks @manwar!