Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl upgrade for regular host names #77

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Commits on Jan 31, 2024

  1. Fix ssl upgrade for regular host names

    Due to a buggy string match, SSL_hostname is always undef: matching
    ":" in host_port, which always has a colon between the host and the
    port. This leads to "certificate verify failed" openssl error
    (observed along with a proxy negotiating TLVv1.3).
    
    I suspect this is openssl trying to compare the hostname (which we do
    not pass) in the server certificate CN / SAN.
    
    Fixes regression introduced in v6.12:
    
    6e9101b Making it possible to use IPv6 in https call...
    digint committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    55a8056 View commit details
    Browse the repository at this point in the history