Improve escaping of unwanted characters #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
force-pushed
the
master
branch
from
5dcfddf
to
3a2965a
Compare
happy-barney
force-pushed
the
master
branch
from
f16af15
to
b1ad3dd
Compare
|
only one windows test failed due setup failure |
oalders
reviewed
Oct 6, 2022
t/escape.t
Outdated
| 'it should recognize character groups' | ||
| ; | ||
|
|
||
| use URI::Escape qw(%escapes); |
There was a problem hiding this comment.
Is this needed? We've already imported %escapes above.
There was a problem hiding this comment.
it is not, removed
oalders
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Sorry @happy-barney , I don't know how this got missed. Thanks for following up on it.
|
I've just released it to CPAN. Thanks, @happy-barney! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Problem identified by issue relies in improper quoting and string evaluation in
uri_escape. Examples of$unsafethat will not behave very friendlykill -9 -1}'