-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 214: add ability to clear history and tests for history #259
Conversation
Thanks @mschae94! |
@petdance this would close a pretty old issue: https://web.archive.org/web/20130622184440/http://code.google.com/p/www-mechanize/issues/detail?id=237 |
Sounds good to me. Are you wanting me to do something? |
Do we need to clear other variables such as $self->{req}, $self->{res} too? |
I think since this is just deleting the stack, we want to keep the information for the last request around. https://metacpan.org/source/OALDERS/WWW-Mechanize-1.88/lib/WWW/Mechanize.pm#L206-218 |
@petdance if you had a moment to eyeball the code, that would be helpful. I didn't see any issues, but more eyes on the code is better. |
I think Are we still supporting Perls all the way back to 5.6.1? Even on ack I require 5.10.1. The test seems to be mixing Test and Test2 style matches. I'm seeing both That's all I'm seeing. All seems sensible to me. |
I see. |
We've been keeping stuff backwards compatible as far as possible unless there's a compelling reason not to.
Yeah, I'm not sure
Thanks for the review @petdance! |
Actually, for the
In |
For what it's worth, I don't see any issues with the changes either. But I'm just a passer-by and I've helped @mschae94 implement them. :) |
Thanks @mschae94, @petdance, @skaji and @simbabque! |
closes #214