Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tags file from repo #296

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Remove tags file from repo #296

merged 1 commit into from
Apr 24, 2020

Conversation

oalders
Copy link
Member

@oalders oalders commented Apr 23, 2020

This file is no longer getting updated and I'm not aware of anyone who
uses it. It would be entirely possibly to continue using something like
this without it being check in to the repository.

This appears to be a vim ctags file

This file is no longer getting updated and I'm not aware of anyone who
uses it. It would be entirely possibly to continue using something like
this without it being check in to the repository.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 328

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.118%

Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 736
Relevant Lines: 782

💛 - Coveralls

Copy link
Member

@skaji skaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petdance
Copy link
Contributor

I was the one that used the tags file.

I checked it into the repo as a way of seeing how symbols changed over time between releases.

@petdance
Copy link
Contributor

I'd bet there's a Makefile target for tags that you could delete, too.

@oalders
Copy link
Member Author

oalders commented Apr 24, 2020

I'd bet there's a Makefile target for tags that you could delete, too.

I dug around the old Makefile.PL and found

WWW-Mechanize/Makefile.PL

Lines 115 to 120 in 9c0efd3

tags:
ctags -f tags --recurse --totals \
--exclude=blib \
--exclude=.svn \
--exclude='*~' \
--languages=Perl --langmap=Perl:+.t \

Now that Dist::Zilla creates the Makefile.PL that has already been removed, but now I see how the tags were being created. :)

Thanks @petdance and @skaji!

@oalders oalders merged commit e466e74 into master Apr 24, 2020
@oalders oalders deleted the oalders/remove-tags branch April 24, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants