-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump HTTP::Daemon test dependency to 6.12 #300
Conversation
0f9164a
to
943a16e
Compare
HTTP::Daemon 6.10 returns a correct WWW-Mechanize/t/local/log-server Lines 16 to 23 in f1a0235
WWW-Mechanize/t/local/referer-server Lines 10 to 17 in f1a0235
@oalders Could you remove these lines? |
@skaji I have removed the lines. Is that what you had in mind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oalders Thank you. LGTM
FYI: We don't need Socket or URI module anymore, so you may want to remove them.
diff --git t/local/log-server t/local/log-server
index a77b1e6..c280cdd 100644
--- t/local/log-server
+++ t/local/log-server
@@ -3,7 +3,6 @@ use strict;
use HTTP::Daemon ();
use CGI 4.08;
use Getopt::Long;
-use Socket ();
$|++;
@@ -13,8 +12,7 @@ GetOptions(
my $d = HTTP::Daemon->new or die;
-my $url = URI->new($d->url);
-print "$url\n";
+print $d->url, "\n";
my ($filename,$logfile) = @ARGV[0,1];
if ($filename) {
diff --git t/local/referer-server t/local/referer-server
index a6f206b..9ecd393 100644
--- t/local/referer-server
+++ t/local/referer-server
@@ -1,14 +1,11 @@
# Thanks to merlyn for nudging me and giving me this snippet!
use HTTP::Daemon ();
-use URI::URL;
-use Socket ();
$|++;
my $d = HTTP::Daemon->new or die;
-my $lhurl = URI::URL->new( $d->url );
-print $lhurl->as_string, "\n";
+print $d->url, "\n";
$counter = 5;
while ($counter-- and my $c = $d->accept) {
44649ef
to
4d18e42
Compare
No description provided.