Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for dumping and accessing empty value input elements #312

Closed
wants to merge 1 commit into from
Closed

add tests for dumping and accessing empty value input elements #312

wants to merge 1 commit into from

Conversation

simbabque
Copy link
Contributor

I created libwww-perl/HTML-Parser#17 from this. Quite an investigation, but good fun. There's a TODO in the tests now, I hope that's ok.

Closes #125

@simbabque simbabque requested a review from oalders October 3, 2020 22:09
oalders
oalders approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simbabque!

@oalders
Copy link
Member

oalders commented Oct 4, 2020

I handled the merge conflict and the resulting merge manually. This is now in master.

@oalders oalders closed this Oct 4, 2020
@simbabque
Copy link
Contributor Author

Thanks @oalders I think we've been too busy with the Changes file over the weekend. I'm going to go close #125.

@simbabque simbabque mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalders oalders oalders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WM: Hidden fields don't appear in current_form if their value=""
2 participants
@simbabque @oalders