Don't undef $nntp until we're finished with it.

Fixes https://rt.cpan.org/Ticket/Display.html?id=112710
libwww-perl · Mar 2, 2017 · 5430d0e · 5430d0e
1 parent 4a0bd13
commit 5430d0e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/LWP/Protocol/nntp.pm b/lib/LWP/Protocol/nntp.pm
@@ -103,9 +103,9 @@ sub request {
     my $art = $nntp->$get("<$groupart>");
     unless ($art) {
         $nntp->quit;
-        $nntp = undef;
         $response->code(HTTP::Status::RC_NOT_FOUND);
         $response->message($nntp->message);
+        $nntp = undef;
         return $response;
     }
 

diff --git a/t/base/protocols/nntp.t b/t/base/protocols/nntp.t
@@ -0,0 +1,12 @@
+use strict;
+use warnings;
+
+use LWP::UserAgent ();
+use Test::More;
+use Test::RequiresInternet ( 'nntp.perl.org' => 119 );
+
+plan tests => 1;
+my $ua = LWP::UserAgent->new;
+
+my $res = $ua->get('nntp://nntp.perl.org/blahblahblah@blahblahblah');
+is($res->code, 404, '404 on fake nntp url');