Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply perlimports to tests #418

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Apply perlimports to tests #418

merged 4 commits into from
Oct 4, 2022

Conversation

oalders
Copy link
Member

@oalders oalders commented Oct 3, 2022

  • Add perlimports.toml
  • Apply perlimports to tests

simbabque
simbabque previously approved these changes Oct 3, 2022
Copy link
Contributor

@simbabque simbabque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simbabque
Copy link
Contributor

Thanks. Let's wait with merging until the spelling test failure is sorted.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 61.32% // Head: 61.25% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (d5e617a) compared to base (88c66e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   61.32%   61.25%   -0.08%     
==========================================
  Files          14       14              
  Lines        1386     1386              
  Branches      393      393              
==========================================
- Hits          850      849       -1     
  Misses        354      354              
- Partials      182      183       +1     
Impacted Files Coverage Δ
lib/LWP/Protocol.pm 81.18% <0.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oalders
Copy link
Member Author

oalders commented Oct 4, 2022

@simbabque I believe this is ready for review/merge.

Copy link
Contributor

@simbabque simbabque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

@simbabque simbabque merged commit 935e592 into master Oct 4, 2022
@simbabque
Copy link
Contributor

I think we can ignore the coverage. If it's accurate I have no idea how it lost partial coverage of that line by moving around imports in tests. Makes me wonder how trustworthy that report really is.

@oalders oalders deleted the oalders/perlimports branch October 4, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants