-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply perlimports to tests #418
Conversation
oalders
commented
Oct 3, 2022
- Add perlimports.toml
- Apply perlimports to tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks. Let's wait with merging until the spelling test failure is sorted. |
e04de9e
to
d5e617a
Compare
Codecov ReportBase: 61.32% // Head: 61.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
- Coverage 61.32% 61.25% -0.08%
==========================================
Files 14 14
Lines 1386 1386
Branches 393 393
==========================================
- Hits 850 849 -1
Misses 354 354
- Partials 182 183 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@simbabque I believe this is ready for review/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you.
I think we can ignore the coverage. If it's accurate I have no idea how it lost partial coverage of that line by moving around imports in tests. Makes me wonder how trustworthy that report really is. |