Apply perlimports to tests

Changes

@@ -1,6 +1,7 @@
 Change history for libwww-perl
 
 {{$NEXT}}
+    - Apply perlimports to tests (GH#418) (Olaf Alders)
 
 6.67      2022-06-14 20:20:12Z
     - Remove undocumented LWP::Version sub (GH#416) (James Raspass)

cpanfile

@@ -58,6 +58,7 @@ on 'test' => sub {
 on 'develop' => sub {
     requires 'Authen::NTLM' => '1.02';
     requires 'Pod::Coverage::TrustPod';
+    requires 'Pod::Spell' => '1.25';
     requires 'Test::EOL' => '2.00';
     requires 'Test::LeakTrace' => '0.16';
     requires 'Test::MinimumVersion';

perlimports.toml

@@ -0,0 +1,25 @@
+# Valid log levels are:
+# debug, info, notice, warning, error, critical, alert, emergency
+# critical, alert and emergency are not currently used.
+#
+# Please use boolean values in this config file. Negated options (--no-*) are
+# not permitted here. Explicitly set options to true or false.
+#
+# Some of these values deviate from the regular perlimports defaults. In
+# particular, you're encouraged to leave preserve_duplicates and
+# preserve_unused disabled.
+
+cache                           = false # setting this to true is currently discouraged
+ignore_modules                  = ["Test::More"]
+ignore_modules_filename         = ""
+ignore_modules_pattern          = "" # regex like "^(Foo|Foo::Bar)"
+ignore_modules_pattern_filename = ""
+libs                            = ["lib", "t/lib"]
+log_filename                    = ""
+log_level                       = "warn"
+never_export_modules            = []
+never_export_modules_filename   = ""
+padding                         = true
+preserve_duplicates             = false
+preserve_unused                 = false
+tidy_whitespace                 = true

t/10-attrs.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use Test::More;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 plan tests => 9;
 
 # Prevent environment from interfering with test:

t/base/default_content_type.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use Test::More;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 use HTTP::Request ();
 plan tests => 18;
 

t/base/protocols.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use Test::More;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 plan tests => 7;
 
 my $ua = LWP::UserAgent->new();

t/base/proxy.t

@@ -1,9 +1,9 @@
 use strict;
 use warnings;
 use Test::More;
-use Test::Fatal;
+use Test::Fatal qw( exception );
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 plan tests => 8;
 
 # in case already defined in user's environment

t/base/simple.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 
 use Test::More;
-use LWP::Simple;
+use LWP::Simple qw( RC_NOT_MODIFIED );
 
 plan tests => 1;
 

t/leak/no_leak.t

@@ -9,7 +9,7 @@ use Test::More;
 use Test::Needs 'Test::LeakTrace';
 
 use File::Temp ();
-use LWP::UserAgent;
+use LWP::UserAgent ();
 
 plan skip_all => 'skip leak test in COVERAGE' if $ENV{COVERAGE};
 

t/local/autoload-get.t

@@ -2,8 +2,8 @@ use strict;
 use warnings;
 use Test::More;
 
-use LWP::UserAgent;
-use URI;
+use LWP::UserAgent ();
+use URI ();
 
 plan tests => 4;
 

t/local/autoload.t

@@ -2,9 +2,9 @@ use strict;
 use warnings;
 use Test::More;
 
-use HTTP::Request;
-use LWP::UserAgent;
-use URI;
+use HTTP::Request ();
+use LWP::UserAgent ();
+use URI ();
 
 plan tests => 4;
 

t/local/download_to_fh.t

@@ -2,10 +2,9 @@ use strict;
 use warnings;
 use Test::More;
 
-use File::Temp;
-use LWP::UserAgent;
-use LWP::Simple;
-require LWP::Protocol::file;
+use File::Temp ();
+use LWP::UserAgent ();
+use LWP::Simple qw( $ua );
 
 my $src = File::Temp->new("src-XXXXXXXXX");
 my $dst = File::Temp->new("dst-XXXXXXXXX");

t/local/get.t

@@ -2,9 +2,8 @@ use strict;
 use warnings;
 use Test::More;
 
-use File::Temp 'tempdir';
-use LWP::Simple;
-require LWP::Protocol::file;
+use File::Temp qw( tempdir );
+use LWP::Simple qw( get getprint getstore head );
 
 my $TMPDIR = undef;
 

t/local/http.t

@@ -1,16 +1,15 @@
 use strict;
 use warnings;
 use Test::More;
-use Test::Fatal;
+use Test::Fatal qw( exception );
 
-use Config;
-use FindBin qw($Bin);
+use Config qw( %Config );
+use FindBin qw( $Bin );
 use HTTP::Cookies ();
-use HTTP::Daemon;
-use HTTP::Request;
-use IO::Socket;
-use LWP::UserAgent;
-use URI;
+use HTTP::Daemon ();
+use HTTP::Request ();
+use LWP::UserAgent ();
+use URI ();
 use utf8;
 
 delete $ENV{PERL_LWP_ENV_PROXY};

t/local/httpsub.t

@@ -2,10 +2,9 @@ use strict;
 use warnings;
 use Test::More;
 
-use HTTP::Request;
-use LWP::UserAgent;
-use LWP::Protocol;
-use URI;
+use HTTP::Request ();
+use LWP::UserAgent ();
+use LWP::Protocol ();
 
 plan tests => 2;
 

t/local/protosub.t

@@ -2,10 +2,9 @@ use strict;
 use warnings;
 use Test::More;
 
-use HTTP::Request;
-use LWP::UserAgent;
-use LWP::Protocol;
-use URI;
+use HTTP::Request ();
+use LWP::UserAgent ();
+use LWP::Protocol ();
 
 LWP::Protocol::implementor(http => 'myhttp');
 

t/robot/ua-get.t

@@ -2,13 +2,11 @@ use strict;
 use warnings;
 use Test::More;
 
-use Config;
-use FindBin qw($Bin);
-use HTTP::Daemon;
-use HTTP::Request;
-use IO::Socket;
-use LWP::RobotUA;
-use URI;
+use Config qw( %Config );
+use FindBin qw( $Bin );
+use HTTP::Daemon ();
+use LWP::RobotUA ();
+use URI ();
 use utf8;
 
 delete $ENV{PERL_LWP_ENV_PROXY};

t/robot/ua.t

@@ -2,13 +2,12 @@ use strict;
 use warnings;
 use Test::More;
 
-use Config;
-use FindBin qw($Bin);
-use HTTP::Daemon;
-use HTTP::Request;
-use IO::Socket;
-use LWP::RobotUA;
-use URI;
+use Config qw( %Config );
+use FindBin qw( $Bin );
+use HTTP::Daemon ();
+use HTTP::Request ();
+use LWP::RobotUA ();
+use URI ();
 use utf8;
 
 delete $ENV{PERL_LWP_ENV_PROXY};

xt/author/live/apache-http10.t

@@ -3,8 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('www.google.com' => 80);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 plan tests => 2;
 

xt/author/live/jigsaw/auth-b.t

@@ -3,8 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 plan tests => 9;
 

xt/author/live/jigsaw/auth-d.t

@@ -3,8 +3,7 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
 
 {
 

xt/author/live/jigsaw/chunk.t

@@ -3,8 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 plan tests => 8;
 

xt/author/live/jigsaw/md5-get.t

@@ -3,9 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use Digest::MD5 qw(md5_base64);
-use HTTP::Request;
-use LWP::UserAgent;
+use Digest::MD5 qw( md5_base64 );
+use LWP::UserAgent ();
 
 my $tests = 5;
 plan tests => $tests;

xt/author/live/jigsaw/md5.t

@@ -3,9 +3,9 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use Digest::MD5 qw(md5_base64);
-use HTTP::Request;
-use LWP::UserAgent;
+use Digest::MD5 qw( md5_base64 );
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 my $tests = 5;
 

xt/author/live/jigsaw/neg-get.t

@@ -3,7 +3,7 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 
 plan tests => 2;
 

xt/author/live/jigsaw/neg.t

@@ -3,8 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 plan tests => 2;
 

xt/author/live/jigsaw/redirect-post.t

@@ -3,10 +3,10 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
-use JSON::PP qw(encode_json);
-use Encode qw(encode_utf8);
+use HTTP::Request ();
+use LWP::UserAgent ();
+use JSON::PP qw( encode_json );
+use Encode qw( encode_utf8 );
 
 plan tests => 10;
 

xt/author/live/jigsaw/te.t

@@ -3,8 +3,8 @@ use warnings;
 use Test::More;
 use Test::RequiresInternet ('jigsaw.w3.org' => 443);
 
-use HTTP::Request;
-use LWP::UserAgent;
+use HTTP::Request ();
+use LWP::UserAgent ();
 
 SKIP: {
     skip 'LIVE_JIGSAW_TESTS not enabled', 3 if $ENV{NO_JIGSAW};

xt/author/live/online.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use Test::More;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 
 plan tests => 4;
 

xt/author/misc/dbmrobot

@@ -2,9 +2,9 @@
 use strict;
 use warnings;
 
-use LWP::RobotUA;
-use URI::URL;
-use WWW::RobotRules::AnyDBM_File;
+use LWP::RobotUA ();
+use URI::URL qw( url );
+use WWW::RobotRules::AnyDBM_File ();
 
 my $url = url(shift) || die "Usage: $0 <url>\n";
 my $botname = "Spider/0.1";

xt/author/misc/get-callback

@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 
 my $url = shift || "";
 $url = "http://localhost:8080/$url" unless $url =~ /:/;

xt/author/misc/get-file

@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use LWP::UserAgent;
+use LWP::UserAgent ();
 
 my $file = shift || "";
 my $to = $file;