Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP nntp test for now #317

Merged
merged 1 commit into from
May 6, 2019
Merged

SKIP nntp test for now #317

merged 1 commit into from
May 6, 2019

Conversation

oalders
Copy link
Member

@oalders oalders commented May 6, 2019

Test::RequiresInternet doesn't seem to handle the case of nntp.perl.org
going down. This breaks everyone's tests.

Fixes #307

@oalders
SKIP nntp test for now
d7c3611 
Test::RequiresInternet doesn't seem to handle the case of nntp.perl.org
going down.  This breaks everyone's tests.
genio
genio approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@genio genio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. If we can later find some better way to determine if NNTP is up, that'd be great.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 58.71% when pulling d7c3611 on oalders/nntp into c5e8c73 on master.

@genio genio merged commit 76ad94a into master May 6, 2019
@genio genio deleted the oalders/nntp branch May 6, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genio genio genio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

t/base/protocols/nntp.t fails
3 participants
@oalders @coveralls @genio