Fix a looping regression for 303 responses without a Location header #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in 6.45 had a side effect of making it look at max_redirect only when the Location header is set. The libapache2-mod-perl2 test suite implements a test server that answers with HTTP code 303 without including such a header. RFC 7231 is not very clear on whether Location is required, although the response doesn't make much sense without it. Some googling reveals this is not a new question. https://stackoverflow.com/questions/16194988/for-which-3xx-http-codes-is-the-location-header-mandatory For the sake of robustness I suppose libwww-perl needs to be fixed. Bug-Debian: https://bugs.debian.org/962904
|
Not sure if this reintroduces the issue 6.45 was fixing. The t/redirect tests still pass, though. |
oalders
previously approved these changes
Jun 16, 2020
simbabque
previously approved these changes
Jun 16, 2020
|
@ntyni are you able to have a look at |
oalders
reviewed
Jun 17, 2020
ntyni
force-pushed
the
redirects-without-location
branch
from
7af78df
to
a8ae2b7
Compare
I doubt it regressed with this. It's working for me now. Not sure if it's intentional that only some of the live/jigsaw/ tests are skipped for NO_JIGSAW=1 ? |
|
One of the issues with these live tests is that they can start to fail if there's some throttling going on. I can see that it's now passing, so we can punt on it for now! :) |
oalders
approved these changes
Jun 18, 2020
afresh1
added a commit
to GrantStreetGroup/p5-HealthCheck-Diagnostic-WebRequest
that referenced
this pull request
Aug 25, 2020
This works around a bug in LWP::UserAgent 6.45. libwww-perl/libwww-perl#342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in 6.45 had a side effect of making it look at max_redirect only when the Location header is set.
The libapache2-mod-perl2 test suite implements a test server that answers with HTTP code 303 without including such a header.
RFC 7231 is not very clear on whether Location is required, although
the response doesn't make much sense without it.
Some googling reveals this is not a new question.
https://stackoverflow.com/questions/16194988/for-which-3xx-http-codes-is-the-location-header-mandatory
For the sake of robustness I suppose libwww-perl needs to be fixed.
Bug-Debian: https://bugs.debian.org/962904