Use File::Copy::move to attempt an atomic mirror #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I need to do something for that failed check? |
You can add this to |
In most situations this will Just Work, but some operating systems don't support an atomic rename over an existing file and there's nothing we can do about it.
afresh1
force-pushed
the
atomic-mirror
branch
from
ad57e14
to
c57d22a
Compare
|
Rebased and added the Changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most situations this will Just Work, but some operating systems don't support an atomic rename over an existing file and there's nothing we can do about it.
In any case, the conversation around #217 was a bit overwhelming when IMO File::Copy::move already does the right thing. I think this will fix things while documenting just enough that people will be aware of the caveats.