-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove colon from pair "user:pass" if has no password #31
Conversation
(closes github issue libwww-perl#13)
if (!defined($new) && !length($user)) { | ||
$self->userinfo(undef); | ||
if (!defined($new)) { | ||
$self->userinfo($user || undef); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
length() is significant to protect username 0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joenio are you able to address the comment above?
5dcfddf
to
3a2965a
Compare
Thank you! I've pushed this in a new branch with a fix, so this will close soon. |
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. So change the tests to use a regular expression to match such URIs, so that the presence of the colon is optional. Resolves #744.
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
(closes github issue #13)