Function is not an attribute

[Zig1375]

Sample code:

Object.prototype.some_function = function() {
    console.log('I am some_function');
};

var data = {'key1' : 'value1', 'key2' : 'value2'};

var libxml = require('libxmljs');
var xml = libxml.Document();
var node = xml.node("query");
node.attr(data);

console.log(node.toString(false));

Result:

<query key1="value1" key2="value2" some_function="function () {&#10;    console.log('I am some_function');&#10;}"/>

[defunctzombie]

While this seems strange, I do think this is correct behavior. some_function becomes an enumerable property of all objects. Maybe a hasOwnProperty check would be better; that I would consider over a specific function check.

[polotek]

I would rather see this done using Object.keys. The problem is extending the object prototype, not the fact that it's a function. You should try to avoid that in whatever code you're dealing with.

[defunctzombie]

+1 for Object.keys actually. Just skipped my mind.