Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] V1.0 - RC1 #585

Merged
merged 73 commits into from Mar 29, 2023
Merged

[WIP] V1.0 - RC1 #585

merged 73 commits into from Mar 29, 2023

Conversation

rchipka
Copy link
Member

@rchipka rchipka commented Feb 15, 2021 •
edited

  • Backwards compatible API abstractions rewritten in Typescript
  • Auto-generated Typescript definitions
  • Auto-generated bindings (using SWIG)
  • Auto-generated documentation
  • Support for multi-threaded parsing
  • Support for NodeJS v12+

Done:

  • SWIG wrapper interface for native xmlNode type casts
  • SWIG wrapper interface for single and multithreaded memory allocation
  • SWIG wrapper interface for reference counting of xmlNodes
  • SWIG wrapper interface for multi-threaded API calls
  • Script to convert swig.xml into Typescript definitions
  • XML/HTML Parser API abstractions in Typescript
  • XMLDocument API abstractions in Typescript
  • XMLNode API abstractions in Typescript
  • XMLElement API abstractions in Typescript
  • XMLAttribute API abstractions in Typescript
  • Tests passing: main.ts
  • Tests passing attribute.ts
  • Tests passing document.ts
  • Tests passing element.ts

To-do:

  • xmlNs* ref integrity (separate refcounting strategy)
  • ensure remaining tests pass
  • ensure cross-platform builds on all NodeJS versions

This was referenced Feb 15, 2021
Open
Closed
@rchipka
Initial commit
f9ed79b 
Compile TS before testing

Typescript fixes

Test commit

Initial commit
@tuananh
Copy link
Contributor

tuananh commented Feb 17, 2021

This is huge. Congrats @rchipka

@madelinecameron madelinecameron mentioned this pull request Mar 9, 2021
Open
@Milo123459
Copy link

Any eta for a merge?

@tusbar tusbar mentioned this pull request Mar 31, 2021
Closed
@rchipka
Copy link
Member Author

rchipka commented May 5, 2021

@Milo123459 Currently working past these CI failures

@riley-ciq riley-ciq mentioned this pull request Jun 10, 2021
Open
@rchipka rchipka mentioned this pull request Jun 10, 2021
Open
@totymedli
Copy link

totymedli commented Jun 18, 2021 •
edited

Is there any ETA for this? Maybe an alpha release only for node 14? Also, some docs on how to build this on your own would be helpful.

@rchipka
Copy link
Member Author

rchipka commented Jul 7, 2021

@totymedli All tests are passing with the exception of a few memory leak tests. We can release once these leaks are resolved and automated builds successfully run on each target OS.

@tuananh tuananh mentioned this pull request Oct 20, 2022
Closed
@rchipka
Copy link
Member Author

rchipka commented Mar 29, 2023

finish-line

@rchipka
Copy link
Member Author

rchipka commented Mar 29, 2023

gif

@rchipka rchipka merged commit 4f4ef0f into master Mar 29, 2023
3 checks passed
rchipka added a commit that referenced this pull request Mar 29, 2023
@rchipka
Revert "[WIP] V1.0 - RC1 (#585)"
1168368 
This reverts commit 4f4ef0f.
@tuananh
Copy link
Contributor

tuananh commented Mar 29, 2023

Amazing. Congrats on shipping 1.0 @rchipka I've been a long time user of the project :)

rchipka added a commit that referenced this pull request Mar 29, 2023
@rchipka
V1.0 (#585)
1c75011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rchipka @tuananh @Milo123459 @totymedli @derekxlu @sbonasu @gonzo09 @DannyNemer @rhodgkins