chore: add build steps for node 20 #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: split up macos and windows builds Update test-deploy.yml
fix: correct thing fix: build arm64 chore: also upload regular macos
feat: build for darwin arm64
|
@rchipka Could you take a look at this one when you have time? 🙏 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds build steps for node 20.
It also contains the followin changes:
Splits the macos and windows builds since the MAC build didn't like the
npm config set msvs_version "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise" --globalargument into npm.Removes the "invalid"? npm config command
npm config set spin falsewhich no longer is supported in newer NPM versions.Adds builds steps arm64 macos