Bugfix/640

[kpalatzky]

Fixes #640

[kpalatzky]

@rchipka The pipeline fails due to a GYP error. I cannot fix this error myself.

[rchipka]

We shouldn't use refToNodeType because then we have to use a type assertion.

Instead we should check if the .next/.prev ref is null and return null, otherwise return createXMLReference(XMLNode,...), that way the return type will be inferred correctly.

[rchipka]

Also if you could add a test for this that would be greatly appreciated

[rchipka]

Hmm, although that does raise the question of how to handle casting to XMLElement in nextElement/prevElement

[kpalatzky]

In principle, nextSibling / prevSibling should also return the correct element and not only nextElement / prevElement.

In principle, I think that refToNodeType is already correct. However, the document node should probably still be explicitly checked here so that the types are correct.

An XML element should always be returned for an element reference.

[kpalatzky]

It also seems that the build on ubuntu does work fine. Whats reason why it does fail on macos? I am not familiar with GYP errors.

[rchipka]

Seems like maybe a python version issue considering the error is related to unknown flags for an open() call

[rchipka]

I agree that we should always return an instance that best matches the underlying node ref type, however I'm wondering if there's a way we can do this without a manual type assertion