Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IT sample global volume and sample vibrato. #218

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix IT sample global volume and sample vibrato. #218

merged 1 commit into from
Nov 16, 2020

Commits on Nov 11, 2020

  1. Fix IT sample global volume and sample vibrato. 

    * IT sample global volume was being ignored in sample mode due to
  QUIRK_INSVOL not being enabled. QUIRK_INSVOL is now unconditionally
  enabled for IT modules.
* IT sample global volume was being ignored in instrument mode for
  IT 1.x modules due to QUIRK_INSVOL not being enabled for IT 1.x
  modules. QUIRK_INSVOL is now unconditionally enabled for IT modules.
* Fixed an incorrect bitshift on IT sample vibrato depth that resulted
  in IT sample vibrato being very weak.
* Sample vibrato rate is now rounded instead of truncated. The LFO
  period size should probably eventually be expanded instead.
    @AliceLR
    AliceLR committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    912bc13 View commit details
    Browse the repository at this point in the history