-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature new tpps (binary compare and ternary select) #834
Conversation
@egeor : is this PR ready for review? |
Yes, should be ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@egeor : as discussed offline I helped with fixing the open issue and approved now. However, I don't want to merge without another look by you. As you cannot approve your own PR, please just leave a quick comment, when you have reviewed my minor touch ups. |
Thanks, your touchups look good to me! |
This PR adds new tpps (binary compare and ternary select)