Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections in Unknown values size. #11

Merged
merged 10 commits into from Jul 9, 2023
Merged

Conversation

nisargsuthar
Copy link
Contributor

  • Made corrections for unknown values size for PFV 30, Variants 1 (Version 26) and 2.
  • Document the new section found from WIP research as 'Hash string' as prefetch hash is computed using:
  1. This string only, for normal prefetch files.
  2. This string + a variable combination of (/prefetch: flag, command line arguments), for application hosting prefetch files.

Note to self:
Confirm/discard absence of the Hash string section in PFV 30, Variant 1.

@joachimmetz joachimmetz self-assigned this Jul 8, 2023
@joachimmetz joachimmetz self-requested a review July 8, 2023 10:15
@joachimmetz
Copy link
Member

@nisargsuthar thanks I'll have a closer look later

@nisargsuthar
Copy link
Contributor Author

@joachimmetz

Note to self:
Confirm/discard absence of the Hash string section in PFV 30, Variant 1.

I've confirmed that this section is also seen for Variant 1. Before, you verify and merge this let me further update my PR to reflect this change as well.

@nisargsuthar
Copy link
Contributor Author

nisargsuthar commented Jul 8, 2023

I've updated my parser to handle all cases of Prefetch files including the 4 versions, 2 variants, and 2 categories based on the presence/absence of the hash string section. You may refer to the prefetch.py module for verification purposes.
nisargsuthar/Veritas@cb0c3a0

Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz joachimmetz merged commit 40e96d8 into libyal:main Jul 9, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants