Aligned dialog title behavior to QT #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
||
| #ifdef LIBYUI_VERSION_NUM | ||
| #if LIBYUI_VERSION_AT_LEAST(2,42,3) |
There was a problem hiding this comment.
Is the version check still needed?
There was a problem hiding this comment.
That was required when i added the first title management, it broke old legacy libraries at Suse, I don't know more about that subject ask to @tgoettlicher
There was a problem hiding this comment.
OK, let's leave it in now. When we get more automated tests we can do more clean-up.
mvidner
added a commit
that referenced
this pull request
Feb 24, 2014
BusyCursor fix; Qt consistency: dialog title, seconds in time; Fixed YTree item selection during items population
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does not solve issue #67 but at least aligns Gtk to Qt, and the workaround to get a new title by setting
a new application title works. Moreover sub-dialogs have the same title as main one.