Skip to content

Commit

Permalink
Dropped support for RPM groups also in technical details view (bsc#11…
Browse files Browse the repository at this point in the history
…63594)
  • Loading branch information
shundhammer committed Feb 17, 2020
1 parent f9c4f24 commit 05528f5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
24 changes: 0 additions & 24 deletions src/YQPkgTechnicalDetailsView.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "YQPkgTechnicalDetailsView.h"
#include "YQi18n.h"
#include "utf8.h"
//Added by qt3to4:
#include <QList>

using std::list;
using std::string;
Expand Down Expand Up @@ -125,26 +123,6 @@ YQPkgTechnicalDetailsView::authorsListCell( ZyppPkg pkg ) const
}


QString
YQPkgTechnicalDetailsView::formatRpmGroup( ZyppPkg pkg ) const
{
QStringList groups = fromUTF8( pkg->group() ).split( '/', QString::KeepEmptyParts );

// Translate group path components

QStringList translated;

for ( QStringList::const_iterator it = groups.begin();
it != groups.end();
++it )
{
translated.append( QString::fromUtf8( dgettext( "rpm-groups", (*it).toUtf8() ) ) );
}

return translated.join( "/" );
}


QString
YQPkgTechnicalDetailsView::simpleTable( ZyppSel selectable,
ZyppPkg pkg )
Expand All @@ -158,7 +136,6 @@ YQPkgTechnicalDetailsView::simpleTable( ZyppSel selectable,
*pkg == selectable->installedObj() ?
row( hcell( _( "Install Time:" ) ) + cell( pkg->installtime() ) ) : "";

html += row( hcell( _( "Package Group:" ) ) + cell( formatRpmGroup( pkg ) ) );
html += row( hcell( _( "License:" ) ) + cell( pkg->license() ) );
html += row( hcell( _( "Installed Size:" ) ) + cell( pkg->installSize().asString() ) );
html += row( hcell( _( "Download Size:" ) ) + cell( pkg->downloadSize().asString() ) );
Expand Down Expand Up @@ -196,7 +173,6 @@ YQPkgTechnicalDetailsView::complexTable( ZyppSel selectable,
html += row( hcell( _( "Version:" ) ) + cell( p1->edition().asString() ) + cell( p2->edition().asString() ) );
html += row( hcell( _( "Build Time:" ) ) + cell( p1->buildtime() ) + cell( p2->buildtime() ) );
html += row( hcell( _( "Install Time:" ) ) + cell( p1->installtime() ) + cell( p2->installtime() ) );
html += row( hcell( _( "Package Group:" ) ) + cell( formatRpmGroup( p1 ) ) + cell( formatRpmGroup( p2 ) ) );
html += row( hcell( _( "License:" ) ) + cell( p1->license() ) + cell( p2->license() ) );
html += row( hcell( _( "Installed Size:" ) ) + cell( p1->installSize().asString() ) + cell( p2->installSize().asString() ) );
html += row( hcell( _( "Download Size:" ) ) + cell( p1->downloadSize().asString() ) + cell( p2->downloadSize().asString() ) );
Expand Down
5 changes: 0 additions & 5 deletions src/YQPkgTechnicalDetailsView.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@ class YQPkgTechnicalDetailsView : public YQPkgGenericDetailsView
* Returns a string containing HTML code for a package's authors list.
**/
QString authorsListCell( ZyppPkg pkg ) const;

/**
* Format an RPM group. Retrieves the translated ( ! ) version.
**/
QString formatRpmGroup( ZyppPkg pkg ) const;
};


Expand Down

0 comments on commit 05528f5

Please sign in to comment.