Better error handling for missing package selector / pattern selector icons #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
pushed a commit
to mvidner/libyui-combined-alpha-3
that referenced
this pull request
Jan 15, 2021
…ing-icons-01 Better error handling for missing package selector / pattern selector icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
https://trello.com/c/27ozQgUS/452-ostumbleweed-p1-1114654-build-20181102-patternselector-icons-missing-openqa-test-fails-in-selectpatternsandpackages
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1114654
Problem
Status icons in the YQPackageSelector / YQPatternSelector are missing, and it's hard to figure out what's wrong.
Fix
This is not yet a real fix, but it will greatly help to debug future similar issues:
There are now error messages in the log (once per missing icon, not any more often), and a missing status icon will now be displayed as a small red square so it's at least obvious that something is wrong.
I already told QA (Rodion) about this; it might help them in the future.
Also, this cleans up some accumulated cruft from the last 6-7 years.
You might want to view the diff without whitespace changes (checkbox at the upper right corner in the GitHub diff view).