Fixed Qt 5.15 Deprecated Warnings #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2020
jreidinger
approved these changes
Mar 24, 2020
jreidinger
reviewed
Mar 24, 2020
| @@ -301,7 +301,7 @@ void QY2Styler::registerChildWidget( QWidget * parent, QWidget * widget ) | |||
| { | |||
| // Don't use yuiDebug() here - deadlock (reason unknown so far) in thread handling! | |||
|
|
|||
| qDebug() << "Registering " << widget << " for parent " << parent << endl; | |||
| qDebug() << "Registering " << widget << " for parent " << parent << Qt::endl; | |||
There was a problem hiding this comment.
it is not clear for me why here change is required and e.g. at https://github.com/libyui/libyui-qt/pull/127/files#diff-f5ec953a1b429e30261a13ae62c10577R245 it uses plain endl.
There was a problem hiding this comment.
I understand QTextStream used to have its own ::endl() which is now gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
https://trello.com/c/UJ8pBbFm/
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1165118
Changes
All changes were really trivial.
Related PRs
libyui/libyui-qt-pkg#85
libyui/libyui-qt-graph#36