Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Widget: MenuBar (Qt UI Implementation) #130

Merged
merged 6 commits into from Aug 12, 2020
Merged

New Widget: MenuBar (Qt UI Implementation) #130

merged 6 commits into from Aug 12, 2020

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Jul 9, 2020

Trello

https://trello.com/c/4GtDpmMo/

Overview

This adds a MenuBar widget to the Qt UI.

For more details, see the main PR for this feature:

https://github.com/libyui/libyui/pull/169

Travis Build Failure

This doesn't build because the image used by Travis does not yet contain the libyui with the new features. This is expected.

Related PRs

src/YQMenuBar.cc Outdated Show resolved Hide resolved
src/YQMenuButton.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Qt expert either, but this looks incredibly reasonable to me.

@shundhammer shundhammer changed the title WIP: New Widget: MenuBar (Qt UI Implementation) New Widget: MenuBar (Qt UI Implementation) Aug 11, 2020
@shundhammer shundhammer merged commit 6ddf269 into libyui:master Aug 12, 2020
@shundhammer shundhammer deleted the huha-menu-01 branch August 12, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants