Honor Menu Item Enabled/Disabled State when Rebuilding Menu Item Tree #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla
https://bugzilla.opensuse.org/show_bug.cgi?id=1178394
Problem
When the content of a YaST dialog changes and keyboard shortcut conflicts are resolved, all menu items of a MenuBar are enabled, even though they are explicitly disabled internally.
This affects only the Qt UI.
Found by Ancor during development of
https://trello.com/c/MRJhR5x6/2080-1-partitioner-disable-menu-entries-from-device-and-add-when-an-nfs-device-is-selected
Fix
When rebuilding the menu item tree, set the enabled/disabled state of the corresponding Qt object (QAction or QMenu) according to the YMenuItem's enabled/disabled state.
Test Case
yast/yast-ycp-ui-bindings#60
See also the test instructions there.