Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile with Qt 5.7 #59

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Fix compile with Qt 5.7 #59

merged 2 commits into from
Sep 26, 2016

Conversation

shumski
Copy link

@shumski shumski commented Sep 25, 2016

Hrvoje Senjan added 2 commits September 25, 2016 18:49
By using non-deprecated classes
@mvidner
Copy link
Member

mvidner commented Sep 26, 2016

Thanks! I have created a Bugzilla ticket for this so that we can include the fix in SLE too.

@shundhammer
Copy link
Contributor

LGTM

@shundhammer
Copy link
Contributor

shundhammer commented Sep 26, 2016

Background: When not-that-important Qt classes might become binary incompatible because they are not PIMPL'ed and they need some more data members, they introduce a new one like that QStyleOptionProgressBarV2, so newer code can use that one with the added data member, while old code remains working with the unchanged class.

When a new Qt version (a new major release) comes along, they simply rename the latest V2 (or later) version to the normal name without V2 and they deprecate V2, V3 etc. so they can use it again in the new major release.

That ...V2 here probably goes back to Qt4.

@mvidner mvidner merged commit 2cdb7f3 into libyui:master Sep 26, 2016
@mvidner
Copy link
Member

mvidner commented Sep 26, 2016

A fixup was needed because we keep the version number in 3 places: a60ca09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants