Add item selection in YMenuBar #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Sep 15, 2020
rwx788
reviewed
Sep 15, 2020
|
Code LGTM to me, I will do some testing during the day with your code. Good job here ;) |
jknphy
force-pushed
the
add_menu_bar_widget
branch
2 times, most recently
from
2e44ca4
to
123f684
Compare
|
I've tested the changes, works like a charm. @lslezak whenever you have a moment, could you please take a look? |
rwx788
reviewed
Sep 17, 2020
jknphy
force-pushed
the
add_menu_bar_widget
branch
from
123f684
to
c462324
Compare
jknphy
force-pushed
the
add_menu_bar_widget
branch
from
c462324
to
f70f650
Compare
lslezak
approved these changes
Sep 29, 2020
rwx788
reviewed
Oct 1, 2020
| #include "YSelectionBox.h" | ||
| #include "YTimeField.h" | ||
| #include "YWidgetFinder.h" | ||
| #include "YWidget.h" | ||
|
|
||
| #include <boost/algorithm/string.hpp> | ||
|
|
||
| #define YUILogComponent "rest-api" |
There was a problem hiding this comment.
Missed that one, it breaks compilation of ncurses library, because we cannot redefine log component. I will fix that.
mvidner
pushed a commit
to mvidner/libyui-combined-alpha-2
that referenced
this pull request
Dec 14, 2020
…_widget Add item selection in YMenuBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See poo#69559