Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push and pull handlers #31

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

Gitii
Copy link
Contributor

@Gitii Gitii commented Mar 10, 2023

Hi @licanhua,

This PR adds two new handlers:

All clients should happily use these routes and work out of the box.

I also upgraded all dependencies and .net version to 6.0 because .net core 3.1 is eol.
I also added e2e tests for both handlers which cover the happy path and error cases.

Beside that I have noticed that tests based on notepad.exe fail because the "remastered" notepad for windows 11 has a multi-process design (i think). The session creation fails because the created process is not the one with the ui. Pretty tricky use case. winver works as expected.

I would be great if you could review my PR and give feedback.

@Gitii
Copy link
Contributor Author

Gitii commented Mar 10, 2023

@licanhua I recommend creating a publish profile with a standalone configuration (framework independent build to avoid a .net 6 runtime dependency). I haven't found any documentation of the deployment process and therefore decided to let you decide.

@licanhua licanhua merged commit 439f68b into licanhua:main Mar 10, 2023
@licanhua
Copy link
Owner

@Gitii Thanks for your contribution. I published a release for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants