Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIL OFL v1.1 not being detected #523

Closed
ghost opened this issue Dec 21, 2021 · 3 comments
Closed

SIL OFL v1.1 not being detected #523

ghost opened this issue Dec 21, 2021 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 21, 2021

Description

I have got a project that uses the SIL OpenFont License v1.1, but it's detected as "Other".

Steps to reproduce the behavior

  1. Go to my project's GitHub page here (broken link, the project was deleted);
  2. Open the LICENSE file;
  3. See how it's copied from the SIL OFL license's website;
  4. See also how it does not present the permissions, limitations and conditions of the license, as when it's detected.

Expected behavior

I expected GitHub to detect that the license is indeed SIL OFL v1.1, as it did with other projects, such as JetBrains Mono.

@mlinksva
Copy link
Contributor

mlinksva commented Dec 24, 2021

Licensee currently doesn't know about reserved font names, and with one in the text it falls below its matching threshold.

I'd be open to a patch that accounts for reserved font names. It'd be kind of janky, but including in the copyright regex may be the right thing for now; in a way that'd reflect how reserved font names are part of the copyright text in https://github.com/spdx/license-list-XML/blob/23b581d6996c2db8b969d6c8529182ed1b27a628/src/OFL-1.1.xml#L14

GitHub
This is the repository for the master files that comprise the SPDX License List - license-list-XML/OFL-1.1.xml at 23b581d6996c2db8b969d6c8529182ed1b27a628 · spdx/license-list-XML

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2022
@mlinksva
Copy link
Contributor

Fixed by #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant