Enable Exact matcher to detect OFL with a reserved font name #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome! Congrats on your first pull request to Licensee. If you haven't already, please be sure to check out the contributing guidelines. |
saltcandy123
force-pushed
the
add-copyright-fontname-regex
branch
from
46a0acc
to
4d48021
Compare
In SIL OFL 1.1, copyright notice may be two lines to include a reserved font name. This change covers that case and enables Exact matcher to detect such licenses.
saltcandy123
force-pushed
the
add-copyright-fontname-regex
branch
from
4d48021
to
b4c233e
Compare
it took me a few mins to convince myself the copyright matcher test was testing the right thing this clarifies matches copyright fully = no_license copyright with any other text (license or arbitrary) = nil (bc it's the copyright matcher; other matcher would obtain the license and nil respectively)
mlinksva
force-pushed
the
add-copyright-fontname-regex
branch
from
a9a3f5f
to
654d84b
Compare
mlinksva
approved these changes
Apr 7, 2022
|
Congrats on getting your first pull request to Licensee merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #523.
The solution is to expand copyright regex to include the line that mentions a reserved font name, as mentioned on the issue.