Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punish length differences more, give fill-in fields more leeway #475

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Punish length differences more, give fill-in fields more leeway #475

merged 3 commits into from
Jan 14, 2021

Commits on Jan 13, 2021

  1. Punish length differences more, give fill-in fields more leeway 

    Also follow up on 5436184 by
adding - (in addition to /) as a word character so to minimize
wordset differences when one adds a whole URL with -'s in it to
a fill in (would also work for hyphenated names)

Overall this seems right, though it'd be comforting to have a far
larger test corpus. Length shouldn't vary -- licenses shouldn't be
modified -- but it's inevitable with licenses with fill-in fields.

Fixes #474 which was about the former -- a modified Apache 2.0 license.
    @mlinksva
    mlinksva committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    270f76e View commit details
    Browse the repository at this point in the history

  2. forgot to add new fixture

    @mlinksva
    mlinksva committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    04dffbc View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. normalize bullets as - instead of * same as lists so that md lists wi… 

    …th emphasis also normalized to -
    @mlinksva
    mlinksva committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    9937c72 View commit details
    Browse the repository at this point in the history