Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #527

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add Dockerfile #527

merged 2 commits into from
Jan 24, 2022

Conversation

benbalter
Copy link
Contributor

@benbalter benbalter commented Jan 20, 2022

I saw #526, and thought it would be easier to maintain a Dockerfile (and potentially down the line, a Docker image) than try to support Ruby environments on different platforms for users unfamiliar with Ruby.

This addition shouldn't affect day-to-day development, but allows users to run Licensee with the following:

  1. git clone https://github.com/licensee/licensee && cd licensee
  2. docker build . --tag licensee
  3. docker run licensee [COMMAND]

It could also be used to facilitate local development, if people would prefer to develop within the docker container, rather than not their system directly.

I've also added a tiny CI job to build the docker container and verify it works to reduce maintenance and prevent regressions down the line.


View rendered docs/README.md

Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@benbalter benbalter merged commit 95d573f into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the docker branch January 24, 2022 17:53
Copy link

@Hbutlercapone Hbutlercapone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Dockerfile #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants