fix: keep the logics only triggered in main compilation (#22)

licg9999 · Dec 20, 2022 · ac29459 · ac29459
1 parent 0560e1b
commit ac29459
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/e2e/works-with-webpack-configs-in-popular-tools.spec.ts b/e2e/works-with-webpack-configs-in-popular-tools.spec.ts
@@ -29,7 +29,7 @@ const webpackConfig = require('react-scripts/config/webpack.config')(envInQuesti
 webpackConfig.entry = './src/server.js';
 
 webpackConfig.plugins = webpackConfig.plugins.filter(
-  (p) => !['HtmlWebpackPlugin', 'WebpackManifestPlugin'].includes(p.constructor.name)
+  (p) => p.constructor.name !== 'WebpackManifestPlugin'
 );
 
 webpackConfig.plugins.push(new Plugin());
@@ -73,10 +73,6 @@ const webpackConfig = require('@vue/cli-service/webpack.config');
 
 webpackConfig.entry = './src/server.js';
 
-webpackConfig.plugins = webpackConfig.plugins.filter(
-  (p) => !['HtmlWebpackPlugin'].includes(p.constructor.name)
-);
-
 webpackConfig.plugins.push(new Plugin());
 
 module.exports = webpackConfig;

diff --git a/src/Plugin.ts b/src/Plugin.ts
@@ -95,6 +95,9 @@ export class TranspileWebpackPlugin {
     });
 
     compiler.hooks.finishMake.tapPromise(pluginName, async (compilation) => {
+      // Only evaluates new entries in the main compilation.
+      if (compilation.compiler !== compiler) return;
+
       const outputPath = compiler.options.output.path!;
       const outputPathOfNodeModules = path.resolve(outputPath, baseNodeModules);
       const context = compiler.options.context!;