-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8 #685
Merged
AttackingOrDefending
merged 14 commits into
lichess-bot-devs:master
from
MarkZH:finish-typing
May 1, 2023
Merged
Drop support for Python 3.8 #685
AttackingOrDefending
merged 14 commits into
lichess-bot-devs:master
from
MarkZH:finish-typing
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, variables are not as visible as functions to type checkers.
10 tasks
Reduce need for importing from typing
This is ready to merge. |
AttackingOrDefending
approved these changes
May 1, 2023
72aba0e
into
lichess-bot-devs:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On May 1, 2023, lichess-bot officially drops support for Python 3.8 and will require at least Python 3.9 going forward. The main benefit will be to finish type hinting with the
Queue
type. Further changes:MutableSequence
type forMULTIPROCESSING_LIST_TYPE
that describes thechallenge_queue
. This is slightly more generic than the specific type returned bymultiprocessing.Manager().list()
, butMutableSequence
is still an accurate description of what it is. Functions that only read thechallenge_queue
can use aSequence
type to flag modifications as an error.pip
lines from the github actions.restart
toFalse
in lichess-bot.py when testing. Functions seem to be more visible to mypy than variables.