Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #685

Merged
merged 14 commits into from
May 1, 2023

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Apr 10, 2023

On May 1, 2023, lichess-bot officially drops support for Python 3.8 and will require at least Python 3.9 going forward. The main benefit will be to finish type hinting with the Queue type. Further changes:

  • Use the MutableSequence type for MULTIPROCESSING_LIST_TYPE that describes the challenge_queue. This is slightly more generic than the specific type returned by multiprocessing.Manager().list(), but MutableSequence is still an accurate description of what it is. Functions that only read the challenge_queue can use a Sequence type to flag modifications as an error.
  • Put all packages for running tests in requirements.txt and delete the separate pip lines from the github actions.
  • Create a function that sets restart to False in lichess-bot.py when testing. Functions seem to be more visible to mypy than variables.

@MarkZH MarkZH mentioned this pull request Apr 10, 2023
10 tasks
@MarkZH
Copy link
Collaborator Author

MarkZH commented Apr 30, 2023

This is ready to merge.

@AttackingOrDefending AttackingOrDefending merged commit 72aba0e into lichess-bot-devs:master May 1, 2023
15 checks passed
@MarkZH MarkZH deleted the finish-typing branch May 1, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants