-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image for ARM #989
Conversation
We can run the workflow in a branch and create a docker with a special name (e.g. |
Sure, something like that sounds great, I have both amd and arm linux vms available so I should be able to compare both versions from the same branch. Feel free to mingle with this branch to add the required name changes to ensure images aren't confused with the master ones. |
The workflow failed (see the run here) with error:
If you can't fix the multi-platform build (I don't know how hard it is to fix), then creating different dockers for amd and arm seems fine. |
Can you try again @AttackingOrDefending? I added two missing steps to prepare the multi-platform build. |
Done. They were created and uploaded to GHCR and docker hub. |
The one tagged with There's only one change I had to make, because originally I got this error about the version: harcoding a numeric version in Line 1191 in 6aff6a9
But that has to do with your change in versioning.yml to test, so I'd say all good! [06/28/24 14:47:29] INFO Engine configuration OK lichess-bot.py:1149
ERROR Quitting lichess-bot due to an lichess-bot.py:1212
error:
Traceback (most recent call
last):
File
"/lichess-bot/lichess-bot.py",
line 1209, in <module>
start_lichess_bot()
File
"/lichess-bot/lichess-bot.py",
line 1152, in start_lichess_bot
check_python_version()
File
"/lichess-bot/lichess-bot.py",
line 1191, in
check_python_version
this_lichess_bot_version =
version_numeric(__version__)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File
"/lichess-bot/lichess-bot.py",
line 1174, in version_numeric
return [int(n) for n in
version_str.split(".")]
^^^^^^
ValueError: invalid literal for
int() with base 10: 'arm' |
Type of pull request:
Description:
This change should be enough to cross-compile to both AMD and ARM.
It's complex for me to set up all the tokens and registries in my fork to test it though, so let's come up with a testing strategy.
I've been doing this successfully in my BOT's repo
Related Issues:
Closes #988
Checklist:
Screenshots/logs (if applicable):