Remove unneeded Android theme parameters #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't doing anything productive, as they're quickly overridden when BridgeActivity resets the theme. Additionally windowIsTranslucent may trigger this Android issue https://issuetracker.google.com/issues/194427611 , when using 3rd party launchers that support the return to home animation on Android 11+, the Lichess icon may get stuck on the screen.
|
It's not anymore in the capacitor template indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't doing anything productive, as they're quickly overridden when
BridgeActivityresets the theme. AdditionallywindowIsTranslucentmay triggerthis Android issue https://issuetracker.google.com/issues/194427611 , when
using 3rd party launchers that support the return to home animation on
Android 11+, the Lichess icon may get stuck on the screen.
Tested on Android 11+ with and without GestureNavContract and with and without dark mode.
Also tested on Android 8.0 to verify this doesn't introduce splash screen issues on older Android versions.
I was unable to find out why these parameters were originally added.