Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode workspace for easier repo navigation #35

Merged
merged 2 commits into from Dec 5, 2023

Conversation

Juesto
Copy link
Contributor

@Juesto Juesto commented Nov 28, 2023

solves the need of opening a separate folder/workspace tab to work on cloned repositories (eg lila)
this can be deployed in .gitpod.yml by appending workspaceLocation: lila-docker/lichess.code-workspace # Relative to /workspace dir
intentionally left this out because this change would cause existing users to land at a blank canvas because of the new workspace instead of the used lila-docker folder workspace or other repositories they opened
the quick solution is tell users to run open /workspace/lila-docker or the relevant repository eg open /workspace/repos/lila in a terminal and finish working on there

@fitztrev
Copy link
Member

Just tested your PR. When it started, it gave me a notification to Open the Workspace. So if we add that line to the gitpod.yml file, you won't have to click that?

intentionally left this out because this change would cause existing users to land at a blank canvas because of the new workspace instead of the used lila-docker folder workspace or other repositories they opened

Do you mean there's an issue if people have a running workspace and then pull these latest changes?

@Juesto
Copy link
Contributor Author

Juesto commented Nov 28, 2023

Just tested your PR. When it started, it gave me a notification to Open the Workspace. So if we add that line to the gitpod.yml file, you won't have to click that?

Correct, adding it to gitpod.yml will open the specified workspace instead of opening the repository local folder as a workspace. for now you can click open the workspace on the file or on the notification to see the new unified workspace.

intentionally left this out because this change would cause existing users to land at a blank canvas because of the new workspace instead of the used lila-docker folder workspace or other repositories they opened

Do you mean there's an issue if people have a running workspace and then pull these latest changes?

People might be confused about "losing" the workspaces due to this drastic unexpected change.
i'd rather avoid significant sudden changes to the user experience, the idea is having a gradual transition. (notification for a while, then making it the default)
its just minor user state data thats stored per workspace

@Juesto Juesto closed this Nov 28, 2023
@Juesto Juesto deleted the patch-3 branch November 28, 2023 03:29
@Juesto Juesto restored the patch-3 branch November 28, 2023 03:29
@Juesto Juesto reopened this Nov 28, 2023
@Juesto
Copy link
Contributor Author

Juesto commented Nov 29, 2023

i realized after the fact that the extensions.json and settings.json from the .vscode folder sort of get moved inside the .code-workspace file and users that never opened the folder workspace might not have the suggested extensions
imo we could put the .gitpod.yml recommended extensions into the standard vscode recommended extensions instead

@fitztrev
Copy link
Member

fitztrev commented Dec 5, 2023

i realized after the fact that the extensions.json and settings.json from the .vscode folder sort of get moved inside the .code-workspace file and users that never opened the folder workspace might not have the suggested extensions imo we could put the .gitpod.yml recommended extensions into the standard vscode recommended extensions instead

Can you clarify this?

@Juesto
Copy link
Contributor Author

Juesto commented Dec 5, 2023

oh, dealing with extensions is a separate issue, just saying in relation to this that we could put recommended extensions in the gitpod.yml instead of defining it through vscode facilities such as .vscode/extensions.json and workspace extensions key.
i mean the extensions are mainly for gitpod, not many people are going to develop with this using regular vscode

@Juesto
Copy link
Contributor Author

Juesto commented Dec 5, 2023

i realized after the fact that the extensions.json and settings.json from the .vscode folder sort of get moved inside the .code-workspace file and users that never opened the folder workspace might not have the suggested extensions imo we could put the .gitpod.yml recommended extensions into the standard vscode recommended extensions instead

Can you clarify this?

extensions.json contain a extensions key and settings.json contain a settings key, workspace extensions and settings respectively.
when using a .code-workspace, those things get moved inside that workspace file

@fitztrev fitztrev merged commit 8c5ef5b into lichess-org:main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants