Skip to content

Commit

Permalink
smaller css block gaps overall, consistent gaps in analyse and puzzle
Browse files Browse the repository at this point in the history
  • Loading branch information
ornicar committed Mar 17, 2024
1 parent c0c284e commit 425604d
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 26 deletions.
11 changes: 7 additions & 4 deletions ui/analyse/css/_layout.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
$analyse-block-gap: $block-gap-half;

body {
/* prevents scroll bar flicker on page height changes */
overflow-y: scroll;
Expand Down Expand Up @@ -83,7 +85,7 @@ body {
'uchat';

@include breakpoint($mq-col2) {
grid-template-columns: var(--col2-uniboard-width) var(--gauge-gap) $col2-uniboard-table;
grid-template-columns: var(--col2-uniboard-width) $analyse-block-gap $col2-uniboard-table;
grid-template-rows: fit-content(0);
grid-template-areas:
'board gauge tools'
Expand All @@ -102,7 +104,7 @@ body {
}

&__underboard {
margin-top: 23px;
margin-top: $analyse-block-gap;
}

.eval-gauge {
Expand All @@ -111,11 +113,11 @@ body {
}

@include breakpoint($mq-col2-uniboard-squeeze) {
grid-template-columns: $col2-uniboard-squeeze-width var(--gauge-gap) $col2-uniboard-squeeze-table;
grid-template-columns: $col2-uniboard-squeeze-width $analyse-block-gap $col2-uniboard-squeeze-table;
}

@include breakpoint($mq-col3) {
grid-template-columns: $col3-uniboard-side var(--gauge-gap) var(--col3-uniboard-width) var(--gauge-gap) $col3-uniboard-table;
grid-template-columns: $col3-uniboard-side $analyse-block-gap var(--col3-uniboard-width) $analyse-block-gap $col3-uniboard-table;
grid-template-rows: auto $chat-height 2.5em 1fr;
grid-template-areas:
'side . board gauge tools'
Expand All @@ -128,6 +130,7 @@ body {
}

.mchat {
margin-top: 0;
min-height: 10em;
}

Expand Down
4 changes: 2 additions & 2 deletions ui/analyse/css/_zh.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ $pocket-height: 60px;
@include breakpoint($mq-col1) {
.pocket {
&-top {
margin-bottom: $analyse-block-gap;
margin-bottom: $block-gap-half;
}

&-bottom {
margin-top: $analyse-block-gap;
margin-top: $block-gap-half;
}
}
}
2 changes: 1 addition & 1 deletion ui/analyse/css/study/relay/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ main.is-relay.has-relay-tour {
}

@include breakpoint($mq-col3) {
grid-template-columns: $col3-uniboard-side var(--gauge-gap) var(--col3-uniboard-width) var(--gauge-gap) $col3-uniboard-table;
grid-template-columns: $col3-uniboard-side $block-gap-half var(--col3-uniboard-width) $block-gap-half $col3-uniboard-table;
grid-template-rows: $mq-col3-side-height;
grid-template-areas:
'side . relay-tour relay-tour relay-tour'
Expand Down
7 changes: 1 addition & 6 deletions ui/ceval/css/_eval-gauge.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
body {
@include fluid-size('--gauge-gap', 8px, 17px);
}
$analyse-block-gap: var(--gauge-gap);

.eval-gauge {
width: var(--gauge-gap);
width: $block-gap-half;
position: relative;
background: if($theme-light, #fff, #a0a0a0);
overflow: hidden;
Expand Down
8 changes: 5 additions & 3 deletions ui/common/css/abstract/_uniboard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ $col3-uniboard-controls: 3rem;
$col3-min-bottom-margin: 1rem;

$col3-uniboard-max-width: calc(
100vw - #{$col3-uniboard-side-min} - #{$block-gap} - var(--gauge-gap, #{$block-gap}) - #{$col3-uniboard-table-min} -
2 * var(--main-margin, 0px) - #{$scrollbar-width}
100vw - #{$col3-uniboard-side-min} - #{$block-gap} - #{$col3-uniboard-table-min} - 2 * var(
--main-margin,
0px
) - #{$scrollbar-width}
);
$col3-uniboard-max-height: calc(100vh - #{$site-header-outer-height} - #{$col3-min-bottom-margin});
$col3-uniboard-max-size: min(#{$col3-uniboard-max-width}, #{$col3-uniboard-max-height});
Expand All @@ -45,7 +47,7 @@ $col2-uniboard-table: $col3-uniboard-table;
$col2-uniboard-controls: $col3-uniboard-controls;

$col2-uniboard-max-width: calc(
100vw - var(--gauge-gap, #{$block-gap}) - #{$col3-uniboard-table-min} - 2 * var(--main-margin, 0px) - #{$scrollbar-width}
100vw - #{$block-gap-half} - #{$col3-uniboard-table-min} - 2 * var(--main-margin, 0px) - #{$scrollbar-width}
);
$col2-uniboard-max-height: $col3-uniboard-max-height;
$col2-uniboard-max-size: min(#{$col2-uniboard-max-width}, #{$col2-uniboard-max-height});
Expand Down
6 changes: 3 additions & 3 deletions ui/common/css/abstract/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ $img-path: '../images';

$viewport-min-width: 320px;

$block-gap: 2vmin;
$block-gap: 1.5vmin;
$block-gap-half: 1vmin;

$block-gap-h: 2vh;
$block-gap-w: 2vw;
$block-gap-h: 1.5vh;
$block-gap-w: 1.5vw;
$block-gap-w-half: 1vw;

$box-radius-size: 4px;
Expand Down
12 changes: 7 additions & 5 deletions ui/puzzle/css/_layout.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
$puzzle-block-gap: $block-gap-half;

#main-wrap {
--main-max-width: calc(100vh - #{$site-header-outer-height} - #{$col1-uniboard-controls});

Expand Down Expand Up @@ -55,14 +57,14 @@
}

grid-template-areas: 'board' 'controls' 'tools' 'session' 'kb-move' 'side';
grid-row-gap: $block-gap;
grid-row-gap: $puzzle-block-gap;

&__moves {
display: none;
}

@include breakpoint($mq-col2) {
grid-template-columns: var(--col2-uniboard-width) var(--gauge-gap) $col2-uniboard-table;
grid-template-columns: var(--col2-uniboard-width) $puzzle-block-gap $col2-uniboard-table;
grid-template-rows: fit-content(0);
grid-template-areas:
'board gauge tools'
Expand All @@ -76,7 +78,7 @@
}

@include breakpoint($mq-col2-uniboard-squeeze) {
grid-template-columns: $col2-uniboard-squeeze-width var(--gauge-gap) $col2-uniboard-squeeze-table;
grid-template-columns: $col2-uniboard-squeeze-width $puzzle-block-gap $col2-uniboard-squeeze-table;
}

@include breakpoint($mq-col3) {
Expand All @@ -85,12 +87,12 @@
'side . session . controls'
'side . kb-move . controls'
'side . . . .';
grid-template-columns: $col3-uniboard-side $block-gap var(--col3-uniboard-width) var(--gauge-gap) $col3-uniboard-table;
grid-template-columns: $col3-uniboard-side $puzzle-block-gap var(--col3-uniboard-width) $block-gap-half $col3-uniboard-table;
}

&__side {
display: grid;
grid-gap: $block-gap;
grid-gap: $puzzle-block-gap;
grid-template-areas: 'user' 'theme' 'metas' 'config';

.puzzle-replay & {
Expand Down
4 changes: 2 additions & 2 deletions ui/puzzle/css/_tools.scss
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@

position: relative;
height: $col3-uniboard-controls;
margin-top: #{-$block-gap};
margin-top: #{-$puzzle-block-gap};

@include breakpoint($mq-col1) {
height: $col1-uniboard-controls;
}

// height: calc(#{$puzzle-history-height} + #{$block-gap});
// height: calc(#{$puzzle-history-height} + #{$puzzle-block-gap});
.jumps {
position: relative;
flex: 1 1 auto;
Expand Down

0 comments on commit 425604d

Please sign in to comment.