Merge pull request #14885 from allanjoseph98/spinner-fix

Use existing json data to determine if analysis is completed
lichess-org · Mar 16, 2024 · d78a422 · d78a422
2 parents 9949d9f + bc14c94
commit d78a422
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ui/analyse/src/study/interfaces.ts b/ui/analyse/src/study/interfaces.ts
@@ -123,6 +123,7 @@ export interface StudyChapter {
 }
 
 export interface StudyChapterServerEval {
+  done: boolean;
   path: string;
 }
 

diff --git a/ui/analyse/src/study/serverEval.ts b/ui/analyse/src/study/serverEval.ts
@@ -13,7 +13,9 @@ export default class ServerEval {
   constructor(
     readonly root: AnalyseCtrl,
     readonly chapterId: () => string,
-  ) {}
+  ) {
+    site.pubsub.on('analysis.server.progress', this.updateChart);
+  }
 
   reset = () => {
     this.requested = false;
@@ -46,9 +48,8 @@ export function view(ctrl: ServerEval): VNode {
     }),
   });
 
-  site.pubsub.on('analysis.server.progress', ctrl.updateChart);
-
-  const loading = mainline.find(ctrl.root.partialAnalysisCallback);
+  const loading =
+    !ctrl.root.study?.data.chapter?.serverEval?.done && mainline.find(ctrl.root.partialAnalysisCallback);
   return h('div.study__server-eval.ready.', loading ? [chart, chartSpinner()] : chart);
 }