Team join requests not disappearing

[VTChess]

There is a bug where the number of join requests for teams that you have to review doesn't go away in some cases. Here are screenshots from 2 of my friends as examples:

In this example, JoshHiban says he has had a notification for 4 team join requests for around a year, even though when he clicks on them, it says there are 0 requests to review. He does not know what initially caused this to occur, but he speculated that they were join requests for an old team that got closed.

This example happened recently to both myself and djchessdog. There was a titled player who had requested over a year ago to join one of our teams, but not long after, his account got closed. For the past year, we let his join request sit in our queue to review (it was still sitting there, even though though the titled player's account had been closed), but then yesterday, after what I assume was 1 year since the account was closed, the join request disappeared from our queue, but the notification of 1 join request has still remained.

[kraktus]

My guess would that it’s related to legacy requests preceding #9743

[kraktus]

Tested closing a team with pending requests, and could not reproduce, will investigate further.

[theherk]

In reference to this forum post, I believe my account is in this condition. It isn't a problem, but you can reference that account if that aids the hunt.

[VTChess]

I was the original poster of this issue, and my issue never actually did go away. I have continued to have a notification that I have a new Team request, but when I click on it, it says there are 0 join requests.

The issue in my case came from a titled player who requested to join our team, but then their account was closed shortly thereafter. The team leaders decided to leave his request to join our team as a "souvenir" of sorts, but then after 1 year, the join request suddenly went away, but the notification has always remained

[schlawg]

We should probably clear associated team join requests on account closure (when it happens) in the code, but that won't fix cases where it has already happened. VTChess's issue (and possibly theherk's as well) can be easily whack-a-moled by a prod db admin. A more general script could remove all suspended/closed/other accounts from existing team request collections.

[kraktus]

Pretty sure those requests are already cleared when I checked the issue. I think it’s only an issue with older requests.

[schlawg]

does team_request objects get migrated to read only at some point?