Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Move Storage #11304

Closed
Ytw3216 opened this issue Aug 1, 2022 · 14 comments
Closed

Temporary Move Storage #11304

Ytw3216 opened this issue Aug 1, 2022 · 14 comments

Comments

@Ytw3216
Copy link

Ytw3216 commented Aug 1, 2022

This is an obnoxious feature that should be disabled. When the user chooses to close the opening explorer or refresh the browser tab that is an unambiguous signal that the user does NOT want to save a study.Studies are great, but that is not how people use the Opening Explorer.

It is difficult and annoying to use the "clear moves" button because it requires switching away from the opening explorer database, whichis the feature I'm trying to use. Forcing moves to be stored in browser cache without user consent is malicious behavior.

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

a large population like lichess user base, and a large feature set like lichess site, might provide for diversity of usage and use-case. It is possible that even a majority of users feel like you as they would also be using the same features as you.

I comment here, not to deny your experience, but to propose a rewording of your issue that would not assume uniform needs and feature subset usage. lichess has forum where to first vent initial reactions.

Perhaps just take out the first sentence, and all would be fine with me. not a dev, another fellow lichess user who actually need that feature, but not in the context you have shared. in that context I would actually agree that this feature might not be useful.

I would also take out the last sentence. I am like you though. These vents do sustain the motivation to keep efficient at stating what a problem might be. but luckily, here, markdown and editable. once the dust settles.

Conclusion: edit suggestion. trim first and last sentences and your issue is helpful feedabck i would say.
PS: i would revise my emoticon feedback to eyeing one, wihtout the boundary sentences.

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

RE: user reload signal.
I use to complain about the contrary, chrome use to refresh tabs on its own when it thought you were not busy enough on it, or looking at another tab... lichess also used to cycle things for while (live html node deletion and recreation). Reloading is not such a clear user input signal. it is rather a vague event. like rebooting.

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

Rephrasing without the criminal intent attribution: (I can do that too :) )
I do understand the needs of sustained and efficient attention in terms of visual field configuration, and dynamics in relation to your goals as feature user. The great core feature linking in coordination the 2D board, the game mainline, and user or engine created variations allowing seamless postiion exposure and tree navigation, together with the added tool of opening explorer, also coordinated with other 2 modules, listening to your user events is all happening within limited space, and one would rather have the information under focus or creation to be visible compeletly without further manipulations that would make break in the visual continuity. Am i understanding right. The problem might not be the new feature. But you can describe factually your increased disconfort. I just like to explain things to death.

@schlawg
Copy link
Collaborator

schlawg commented Aug 1, 2022

@Dboingue
Just a heads up, if someone is subscribed to an issue, every new comment generates an email to them. You can edit an existing comment using the ellipses menu.

@370417
Copy link
Contributor

370417 commented Aug 1, 2022

My suggestions:

  • Leave the feature on in game replays and in correspondence.
  • Turn it off in /analysis, since that is where users go if they want a blank slate (and where they go for the opening explorer)
  • Less important: avoid displaying the message panel until there is locally stored data; this way we only require attention from the user when the feature is having an effect

If we want to leave this feature enabled everywhere, I think there's a strong argument that this feature should be controlled by an option.

  • Privacy: let users control what is stored about them, like how a browser lets you control cache/cookie/history settings.
  • Ownership: let users control what their computation and their screen real estate is used for.
  • Automation: some people might want to click "clear moves" after every move. Computers are good at automating, and they should be able to automate this too.

If /analysis does not store moves locally, I think having an option is less important.

@Lou-E-303
Copy link

Lou-E-303 commented Aug 1, 2022

I think "For safekeeping and sharing, consider making a study." hits the nail on the head, and it's odd that Lichess uses this in its official messaging around this new feature.

We already have studies. What value does this add to the analysis board? It seems to me that it just blurs the lines between the two, when they were already great as separate entities.

It's fair enough that some people like it, I can only speak for myself. But I'd like to respectfully request that Lichess at least includes a way to turn this off in settings. It is significantly degrading the UX for me.

It also seems to be causing a raft of bugs for various existing features in Lichess e.g. importing FEN via URL. For me, the move numbers which are inset into the move list are rendering weirdly in correspondence games. After I click the 'play X and save premove line' button, the analysis board gets stuck in a repetitive loop of making the same move over and over again, to the point where even clicking the 'back to game' button does nothing and I have to close the tab!

I think @370417's suggestion is a good stop-gap for now, but I'd rather not have to contend with this feature in Correspondence either. Also, this would do nothing to address the bugs.

As I said, this is only my own opinion, but as an aside - so far I've only really seen one or two people speaking out in favour of the feature.

@schlawg
Copy link
Collaborator

schlawg commented Aug 1, 2022

I like it in correspondence.

After I click the 'play X and save premove line' button, the analysis board gets stuck in a repetitive loop of making the same move over and over again, to the point where even clicking the 'back to game' button does nothing and I have to close the tab!

That's interesting. Will fix.

@Dboingue
Copy link

Dboingue commented Aug 1, 2022 via email

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

I think "For safekeeping and sharing, consider making a study." hits the nail on the head

I made a reply to that suggestion in lichess feedback... not doing the job that in game correspondance analysis mode does...

it is good for sharing not for own games. one would have to give up all the game features... or painfully keep a mirror of the game at each user variation creation session in a study. I tried that, and I should ask you to try it too for a whole game... and let me know how much a nail hit it was.... I did it for a while. then gave up about it. i like chess not repetitive motions.

for other reasons about specific of variations handling see my reply:
https://lichess.org/forum/lichess-feedback/temporary-move-storage?page=3#28

first paragraphs are about study. then i recap what I do in correspondance that would make little sense in studies (unless above tedious work around).

@schlawg
Copy link
Collaborator

schlawg commented Aug 1, 2022

I liked Albert's comment but I think the privacy argument weakens the rest of his points. There may yet come a day when amazon can recommend an electric string trimmer based on adware scans of the analysis moves in your browser cache.

But that day is not now. I don't think.

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

https://lichess.org/forum/lichess-feedback/analysis-boards-persisting-between-uses?page=2#16
updated iteration of my view of the problem from informative model user-annoyance feedback post
(that is only one user though).

@Dboingue
Copy link

Dboingue commented Aug 1, 2022

I like it in correspondence.

After I click the 'play X and save premove line' button, the analysis board gets stuck in a repetitive loop of making the same move over and over again, to the point where even clicking the 'back to game' button does nothing and I have to close the tab!

That's interesting. Will fix.

it makes me curious about the interaction between premove storage and local user variation tree storage..

@infiniteflash24
Copy link

infiniteflash24 commented Aug 2, 2022

Adding this as an account/board option button would be a simple fix. The change is obnoxious for my use case. I liked it the way it was before.

@ornicar ornicar closed this as completed in 977670d Aug 3, 2022
ornicar added a commit to ErdoganSeref/lila that referenced this issue Aug 3, 2022
* master: (56 commits)
  yarn run format
  only log non-mod forum post deletion (team) in a server file
  lpv support for local lichess
  upgrade ui deps
  don't log deletion of automated lichess posts
  disable persistence on /analysis - closes lichess-org#11304
  opening refactoring and tree struggle
  New Crowdin updates (lichess-org#11310)
  tweak daily puzzle selection
  Ignore msg security when Lichess sends DMs
  more percent decimal precision
  lazy load opening variation boards with IntersectionObserver
  cache and improve opening page variations
  always show variations on opening pages
  opening abstract family page WIP
  don't log the entire request query string
  oauth tweaks
  fix game embed CSP
  fix analysis CSP for the embed dialog
  fix opening CSP
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants