Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving two correspondence emails per day #12688

Closed
benwh1 opened this issue Apr 15, 2023 · 6 comments · Fixed by #13550
Closed

Receiving two correspondence emails per day #12688

benwh1 opened this issue Apr 15, 2023 · 6 comments · Fixed by #13550

Comments

@benwh1
Copy link

benwh1 commented Apr 15, 2023

Since #12599 was fixed, I'm now receiving two correspondence emails per day instead of one. I get one at 6am (GMT+1) and then another one 10 minutes later.
@ornicar
Copy link
Collaborator

ornicar commented Apr 15, 2023

The fix is ready to go in next deploy

@ornicar ornicar closed this as completed Apr 15, 2023
@travv0
Copy link

travv0 commented May 30, 2023

I enabled these emails a couple weeks ago and have been getting two per day since then, has the fix been deployed?

@ornicar
Copy link
Collaborator

ornicar commented May 31, 2023

Yes, what's your lichess username?

@travv0
Copy link

travv0 commented May 31, 2023

travv0

@ornicar ornicar reopened this May 31, 2023
@ornicar
Copy link
Collaborator

ornicar commented Jun 1, 2023 •
edited

Can you tell me the precise times of the last duplicated email you received @travv0 ?

@travv0
Copy link

travv0 commented Jun 1, 2023 •
edited

12:00 AM and 12:10 AM UTC-5

And it's not an exact duplicate if that helps, the time remaining for games is 10 minutes different so it's generating twice.

kraktus added a commit to kraktus/lila that referenced this issue Sep 6, 2023
@kraktus
Fix double correspondence email notification
ba531c0 
The function `tick()` is run every 10 min, but the emails are sent in a timeframe of 11 minutes, so they can be sent at 5:00 and 5:10. That minute laps was set to be sure at least once per day an email would be sent, but it seems unecessary and produce way too more duplication emails.

fix lichess-org#12688
@kraktus kraktus mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix double correspondence email notification kraktus/lila
3 participants
@ornicar @travv0 @benwh1