Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Practice with computer" defaults the player to white (and computer to black) in Racing Kings games #14116

Open
aebe opened this issue Nov 30, 2023 · 2 comments
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala

Comments

@aebe
Copy link

aebe commented Nov 30, 2023

Exact URL of where the bug happened

https://lichess.org/rBvFqWnG

Steps to reproduce the bug

  1. Play a Racing Kings game as black
  2. Load the game in analysis view.
  3. Attempt to "Practice with computer" from some point in the game

What did you expect to happen?

I should be playing the black pieces, and the computer playing white.

What happened instead?

I am playing the white pieces, and the computer is playing black.

Operating system

Windows 11

Browser and version (or alternate access method)

Chrome 119

Additional information

The "Practice with computer" feature appears to select which color is played by player and which by computer based on board orientation. Racing Kings flips the board orientation to white no matter which color you are playing, so when you click "Practice with computer" it has you play white.

You can get around this by manually flipping the board, but then everything is upside down. When my opponent resigns/runs out of time I often like to play the rest of the game out against the computer, and it would be nice to be able to do that in the normal orientation when I'm playing Racing Kings as black.

@aebe aebe added the bug label Nov 30, 2023
@kraktus kraktus added good first issue Narrow in scope (but not necessarily easy) no scala labels Nov 30, 2023
ross39 added a commit to ross39/lila that referenced this issue Dec 19, 2023
ross39 added a commit to ross39/lila that referenced this issue Dec 19, 2023
ross39 added a commit to ross39/lila that referenced this issue Dec 19, 2023
@Bruceli-iscool
Copy link

replicated the bug

@GideonPotok
Copy link

I can take this one. PR to come in next few days. Great first issue. Reproduced bug locally already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala
Projects
Status: No status
Development

No branches or pull requests

4 participants