Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View the solution" and "Skip this move" are too close together on mobile #15322

Closed
diffen opened this issue May 17, 2024 · 5 comments
Closed

Comments

@diffen
Copy link

diffen commented May 17, 2024

I use my phone a lot to play (website, not the app). In the analysis/retro section the links for "View the solution" and "Skip this move" are too close so I end up clicking "Skip this move" instead of "View the solution".
The fix for this is quite simple. Add the following CSS in ui/analyse/css/_retro.scss inside the .retro-box block:

.choices > a {
    padding-bottom: 0.4em;
 }
@diffen
Copy link
Author

diffen commented May 17, 2024

I created a pull request for this fix: #15324

@Siderite
Copy link

Siderite commented May 18, 2024

I played around with it a bit (without being a UII designer), but if you add the "button" class to the anchors in choices and you use this:

body.mobile .analyse__tools:has(.retro-box) .analyse__moves {
  order: 2;
}

body.mobile .training-box .choices {
  margin-bottom:0;
}

body.mobile .training-box .choices a:nth-child(1) {
  margin-right:1em;
}

it looks like this:
image

@Siderite
Copy link

Siderite commented May 18, 2024

Maybe use button-red for Skip this move.

image

@diffen
Copy link
Author

diffen commented May 18, 2024

@Siderite You're right. Buttons look even better. Could you please make this change?

@Siderite
Copy link

Siderite commented May 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants