Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook-page and prevent default action for links #35

Closed
myadzel opened this issue Jul 12, 2013 · 0 comments
Closed

Hook-page and prevent default action for links #35

myadzel opened this issue Jul 12, 2013 · 0 comments

Comments

@myadzel
Copy link
Contributor

myadzel commented Jul 12, 2013

Found a bug.

When clicking the button (for example) "Create a game" directly, was opened a new page http://en.lichess.org/setup/hook (if you click on the link happened earlier than has been loaded and executed javascript script file).

Solution. Аdd an attribute onclick="return false" to all links of a similar type. This attribute also prevent the opening URL when you hold "Ctrl" and then click left mouse button (opening in a new tab, usually).
myadzel added a commit to myadzel/lila that referenced this issue Jul 12, 2013
@myadzel
fix hook links, issue lichess-org#35
8206c24
myadzel added a commit to myadzel/lila that referenced this issue Jul 12, 2013
@myadzel
fix hook links, issue lichess-org#35, replace tab with spaces
0f7229b
ornicar added a commit that referenced this issue Jul 12, 2013
@ornicar
Merge remote-tracking branch 'myadzel/master'
f2fa51c 
* myadzel/master:
  fix hook links, issue #35, replace tab with spaces
  fix hook links, issue #35
@ornicar ornicar closed this as completed Jul 12, 2013
ornicar pushed a commit that referenced this issue May 7, 2014
@myadzel
fix hook links, issue #35
6e6e08e
ornicar pushed a commit that referenced this issue May 7, 2014
@myadzel
fix hook links, issue #35, replace tab with spaces
c33dde5
ornicar added a commit that referenced this issue May 7, 2014
@ornicar
Merge remote-tracking branch 'myadzel/master'
be1d968 
* myadzel/master:
  fix hook links, issue #35, replace tab with spaces
  fix hook links, issue #35
nathanielkaiserxyz pushed a commit to nathanielkaiserxyz/lila that referenced this issue Mar 28, 2024
@Juesto
Add VSCode workspace for easier repo navigation (lichess-org#35)
8c5ef5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ornicar @myadzel