Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scawy inconsistent keyboawd showtcut UwU #5193

Closed
MikuChan03 opened this issue Jun 14, 2019 · 10 comments
Closed

Scawy inconsistent keyboawd showtcut UwU #5193

MikuChan03 opened this issue Jun 14, 2019 · 10 comments

Comments

@MikuChan03
Copy link

MikuChan03 commented Jun 14, 2019

Hii~~

Senpai, in both puzzles and analysis, the up awwow wesets the boawd to the vewy stawting position. The code in the wespective keyboawd.ts files is like:

kbd.bind(['up', '0'], pweventing(function() { contwol.fiwst(ctwl); ctwl.wedwaw(); }));

Howevew, in wound/swc/keyboawd.ts, it says:

ctwl.usewJump(1); ctwl.wedwaw();

As we can see, duwing wounds of chess, the up awwow sets the boawd to the position aftew the fiwst move!! O.O

This is inconsistent but luckily, all we need to do is change it to

ctwl.usewJump(0); ctwl.wedwaw();

This fixie wixies the pwoblem
xD starts twerking

@lovlas
Copy link

lovlas commented Jun 14, 2019

Translation:

Inconsistent keyboard shortcut:

Dear Chess Friends.

In both puzzles and analysis, the up arrow resets the board to the very starting position. The code in the respective keyboard.ts file is:

kbd.bind(['up', '0'], preventing(function() { control.first(ctrl); ctrl.redraw(); }));

However, in round/src/keyboard.ts, it says:

ctrl.userJump(1); ctrl.redraw();

As we can see, during rounds of chess, the up arrow sets the board to the position after the first move.

This is inconsistent but luckily, all we need to do is change it to:

ctrl.userJump(0); ctrl.redraw();

This seems to solve the problem.

Thanks!

@ddugovic
Copy link
Contributor

On my PC the up and down arrow keys set the first and last positions.

@MikuChan03
Copy link
Author

Lol, no it doesn't consistently in puzzles, analysis and nowmal chess XD

@MikuChan03
Copy link
Author

How long do you think it will take you to copy a line prowided to you with almost no functional diffewence?
Why do you ask for help when you don't have the chawactew to take it? UwU

@ddugovic
Copy link
Contributor

@MikuChan03 I'm just saying... on my PC it works. If you can tell me what browser version to test in, maybe I can understand what you're talking about.

@MikuChan03
Copy link
Author

Go to:
https://lichess.org/a9V5wZC6/black#0
Click somewhere on the lightgray background and press frirst the down arrow, release it, then press the up arrow.

Go to:
https://lichess.org/tv/classical
Click somewhere on the lightgray background and press frirst the down arrow, release it, then press the up arrow.

One up arrow press will jump to the position after the first move, the other won't. The odd one out is the handler for the regular rounds of the chess, puzzles, the analysis board and the rest all reset to the starting position.

@ddugovic
Copy link
Contributor

Thanks, now I see the https://lichess.org/tv/classical up arrow bug (browser: Vivaldi)
image

RoepStoep pushed a commit to RoepStoep/lidraughts that referenced this issue May 5, 2020
@cdecompilador
Copy link

@kirtan0000 internet is a weird place

@liquidovski
Copy link

I have no words.

just check out this guy's comment history lmao https://github.com/search?utf8=%E2%9C%93&q=commenter%3AMikuChan03&type=issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@ddugovic @lovlas @cdecompilador @MikuChan03 @liquidovski and others